Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick fix for 0.4.1 release. #183

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Cherry pick fix for 0.4.1 release. #183

merged 3 commits into from
Nov 7, 2023

Conversation

peterhuene
Copy link
Member

No description provided.

peterhuene and others added 3 commits November 6, 2023 13:14
@peterhuene
Suppress dead code warnings in bindings. (bytecodealliance#182)
7d0d2b5 
This commit suppresses dead code warnings caused by unused imports in the
generated bindings.
@peterhuene
Add release branches to CI.
f17376c
@peterhuene
Bump patch versions.
985c309
@esoterra
Copy link
Collaborator

esoterra commented Nov 6, 2023

Why is wit being version bumped? I don't see any changes for for.

Also, is the release process documented somewhere for context?

@peterhuene
Copy link
Member Author

It's pretty much the same process as wasmtime's: there's a ci/publish.rs script used to bump the crate versions; once the PR to bump the versions is merged, then a tag is created to point at the merged commit. The act of creating the tag will trigger building the release artifacts.

Right now all the crates bump together to simplify things a bit; while technically this could be done to just the bindings crate, it's useful for at least cargo-component and cargo-component-bindings to match on version.

The wit tool shares the cargo-component-core dependency and technically only needs to bump if it bumps; we can probably refine this process a bit in the future to figure out exactly what crate needs bumping.

esoterra
esoterra approved these changes Nov 7, 2023
View reviewed changes
Copy link
Collaborator

@esoterra esoterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peterhuene peterhuene merged commit 2c772f3 into bytecodealliance:release-0.4.0 Nov 7, 2023
6 checks passed
@peterhuene peterhuene deleted the cherry-pick branch November 7, 2023 18:19
peterhuene added a commit that referenced this pull request Nov 8, 2023
@peterhuene
Cherry pick fix for 0.4.1 release. (#183) (#186)
00bab4a 
* Suppress dead code warnings in bindings. (#182)

This commit suppresses dead code warnings caused by unused imports in the
generated bindings.

* Add release branches to CI.

* Bump patch versions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esoterra esoterra esoterra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@peterhuene @esoterra